Ensure all bots are returned during getProductIotMap #70

Merged

aharter merged 1 commit from fix/bot-iot-map into master

2019-12-28 21:34:48 +01:00

aharter commented

2019-12-28 21:26:33 +01:00

(Migrated from github.com)

Fixes #69.
Based on the list in the handler, I wrote a filter function for the EcoVacsHomeProducts list. Basically removing supportType from the items. After double checking with the captured traffic I created for myself, I realized the payload actually contains supportType. Therefore, using EcoVacsHomeProducts is just fine. However, I am not sure which impact it has on the DEEBOT 2017 app. Probably none.

Fixes #69. Based on the list in the handler, I wrote a filter function for the `EcoVacsHomeProducts` list. Basically removing `supportType` from the items. After double checking with the captured traffic I created for myself, I realized the payload actually contains `supportType`. Therefore, using `EcoVacsHomeProducts` is just fine. However, I am not sure which impact it has on the `DEEBOT 2017` app. Probably none.

codecov[bot] commented

2019-12-28 21:27:57 +01:00

(Migrated from github.com)

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files          13       13           
  Lines        2856     2856           
=======================================
  Hits         2536     2536           
  Misses        320      320

Impacted Files	Coverage Δ
bumper/confserver.py	`73.07% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a5365...707a114. Read the comment docs.

# [Codecov](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=h1) Report > Merging [#70](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=desc) into [master](https://codecov.io/gh/bmartin5692/bumper/commit/97a53656eba39bc8595142167d9e662d6e83117a?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/bmartin5692/bumper/pull/70/graphs/tree.svg?width=650&token=Ody2IThbOc&height=150&src=pr)](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #70 +/- ## ======================================= Coverage 88.79% 88.79% ======================================= Files 13 13 Lines 2856 2856 ======================================= Hits 2536 2536 Misses 320 320 ``` | [Impacted Files](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [bumper/confserver.py](https://codecov.io/gh/bmartin5692/bumper/pull/70/diff?src=pr&el=tree#diff-YnVtcGVyL2NvbmZzZXJ2ZXIucHk=) | `73.07% <ø> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=footer). Last update [97a5365...707a114](https://codecov.io/gh/bmartin5692/bumper/pull/70?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

bmartin5692 (Migrated from github.com) approved these changes 2019-12-28 21:34:33 +01:00

bmartin5692 (Migrated from github.com) left a comment

Tested with all 3 apps (iOS).