Update EcoVacsHomeProducts list #131
No reviewers
Labels
No labels
bug
dependencies
duplicate
enhancement
good first issue
help wanted
invalid
question
waiting for fix validation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: mia/bumper#131
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "jspayd/product-list-update"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
See https://github.com/bmartin5692/bumper/issues/130
I was finally able to get a packet sniffing setup at least good enough to get an updated device list, so I've updated it myself (and my vacuum is indeed in the list!).
Testing
My vacuum is shown in the GetGlobalDeviceList response, which only includes vacuums in the EcoVacsHomeProducts list.
The diff provided by git is a bit hard to read, but I wrote a script to verify that no vacuums are removed. There are two existing vacs whose
icons andiconUrls are changed, but otherwise this PR only adds vacuums to the list.Script:
Output:
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.